fix groundedness with no supporting evidence #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1c9a729 in 33 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. trulens_eval/trulens_eval/feedback/provider/base.py:1225
- Draft comment:
The change effectively handles cases where no 'reason' is provided, preventing potential KeyErrors and ensuring the feedback system remains robust. This is a necessary fix for the groundedness feedback functionality. - Reason this comment was not posted:
Confidence changes required:0%
The PR aims to address a bug where the feedback system breaks if no supporting evidence is provided for a statement's groundedness. The change checks if the 'reason' key exists in the 'reason' dictionary before attempting to access it, which prevents a KeyError and allows the feedback system to handle cases where no reason is provided. This is a crucial fix for robustness in feedback generation.
Workflow ID: wflow_x9g9iRRlgxs4Fudq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
epinzur
reviewed
Jun 11, 2024
|
i wonder if when running in deferred mode, this change would prevent trulens from seeing this as a failed evaluation and then would not re-run it. |
It might be as side effect. Anyway all other feedback providers don't fail if the reason can't be found so I think it's better to align to the others' behaviour |
Merged
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jun 28, 2024
* fix groundedness with no supporting evidence * use reason not generated --------- Co-authored-by: Josh Reini <josh.reini@snowflake.com>
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jul 1, 2024
* fix groundedness with no supporting evidence * use reason not generated --------- Co-authored-by: Josh Reini <josh.reini@snowflake.com>
sfc-gh-chu
pushed a commit
that referenced
this pull request
Sep 25, 2024
* fix groundedness with no supporting evidence * use reason not generated --------- Co-authored-by: Josh Reini <josh.reini@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items to add to release announcement:
Currently if you use feedback
groundedness_measure_with_cot_reasonsand one of the hypothesis is returning no supporting evidence, the feedback is completely broken and not even the score is visible. This is due to the fact this feedback implies to always have a "reason" behind the score.Summary:
This PR fixes an issue in the
groundedness_measure_with_cot_reasonsfeedback function to handle cases with no supporting evidence without breaking.Key points:
evaluate_hypothesisfunction inProviderclass to handle missing 'reason' key gracefully.Generated with ❤️ by ellipsis.dev