Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General robustness + fix/update guardrail examples and testing #1275

Merged
merged 24 commits into from
Jul 8, 2024

Conversation

sfc-gh-jreini
Copy link
Contributor

@sfc-gh-jreini sfc-gh-jreini commented Jul 2, 2024

Description

Update and fix e2e pipeline.

Other details good to know for developers

  • Clear TruLens module between each notebook in test pipeline
  • Add prompt key for guardrails in notebooks
  • Remove unneccessary selectors in guardrail feedback function
  • Run dashboard on unused port

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 2, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Jul 2, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 3, 2024
@sfc-gh-jreini sfc-gh-jreini changed the title add missing content for guardrail Update and fix guardrail examples Jul 3, 2024
@sfc-gh-jreini sfc-gh-jreini requested a review from a team July 3, 2024 10:21
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jul 8, 2024
@sfc-gh-jreini sfc-gh-jreini changed the title Update and fix guardrail examples General robustness + fix/update guardrails Jul 8, 2024
@sfc-gh-jreini sfc-gh-jreini changed the title General robustness + fix/update guardrails General robustness + fix/update guardrail examples and testing Jul 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2024
@sfc-gh-jreini sfc-gh-jreini enabled auto-merge (squash) July 8, 2024 18:46
@sfc-gh-jreini sfc-gh-jreini merged commit 168515e into main Jul 8, 2024
9 checks passed
@sfc-gh-jreini sfc-gh-jreini deleted the josh/e2e_fixes_guardrails branch July 8, 2024 18:55
@sfc-gh-jreini sfc-gh-jreini mentioned this pull request Jul 16, 2024
4 tasks
sfc-gh-chu pushed a commit that referenced this pull request Sep 25, 2024
* add missing content for guardrail

* behind docs update

* update llama-index hybrid retriever example

* md updates

* get quickstart working

* rerun quickstarts

* displays for langchain ensemble retriever

* take selectors from feedback guardrail docs

* add timeout to feedback display util

* fmt

* update llama quickstart

* double quotes

* remove unneeded key calling from test_notebooks

* run combine docs to testing

* clear trulens module between each nb in all_tools

* update all tools

* update all tools/clear trulens module between each nb

* fmt

* run dashboard on unused port

* fmt

* remove unneeded line

* add reasoning md for clear modules

* fix typos

---------

Co-authored-by: Josh Reini <joshua.reini@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants