Add s3 credential validation (#2362)

* add string non-empty validation to AWS creds * clean up import spacing * syntax fixup * change to non-empty validation only * convert to lower snake_case - https://protobuf.dev/programming-guides/style/#message-field-names
trufflesecurity · Feb 2, 2024 · f6546ff · f6546ff
1 parent b2074ad
commit f6546ff
Show file tree

Hide file tree

Showing 3 changed files with 141 additions and 89 deletions.
diff --git a/pkg/pb/credentialspb/credentials.pb.go b/pkg/pb/credentialspb/credentials.pb.go
diff --git a/pkg/pb/credentialspb/credentials.pb.validate.go b/pkg/pb/credentialspb/credentials.pb.validate.go
diff --git a/proto/credentials.proto b/proto/credentials.proto
@@ -4,6 +4,8 @@ package credentials;
 
 option go_package = "github.com/trufflesecurity/trufflehog/v3/pkg/pb/credentialspb";
 
+import "validate/validate.proto";
+
 message Unauthenticated {}
 
 message SSHAuth {}
@@ -46,14 +48,14 @@ message KeySecret {
 }
 
 message AWSSessionTokenSecret {
-  string key = 1;
-  string secret = 2;
-  string sessionToken = 3;
+  string key = 1 [(validate.rules).string.min_len = 1];
+  string secret = 2 [(validate.rules).string.min_len = 1]; 
+  string session_token = 3 [(validate.rules).string.min_len = 1];
 }
 
 message AWS {
-  string key = 1;
-  string secret = 2;
+  string key = 1 [(validate.rules).string.min_len = 1];
+  string secret = 2 [(validate.rules).string.min_len = 1];
   string region = 3;
 }