Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s3 credential validation #2362

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Add s3 credential validation #2362

merged 5 commits into from
Feb 2, 2024

Conversation

codevbus
Copy link
Contributor

@codevbus codevbus commented Feb 1, 2024 •
edited
Loading

Description:

adds S3/AWS credential field validation to protobufs.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@codevbus codevbus requested a review from a team as a code owner February 1, 2024 18:41
@codevbus codevbus marked this pull request as draft February 1, 2024 18:41
@codevbus codevbus marked this pull request as ready for review February 1, 2024 20:34
ahrav
ahrav approved these changes Feb 1, 2024
View reviewed changes
proto/credentials.proto Outdated Show resolved Hide resolved
@codevbus codevbus merged commit f6546ff into main Feb 2, 2024
10 checks passed
@codevbus codevbus deleted the add-s3-credential-validation branch February 2, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker dustin-decker approved these changes

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codevbus @dustin-decker @ahrav