Setup SourceUnit interface #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
reviewed
Jun 14, 2023
rosecodym
reviewed
Jun 15, 2023
| // SourceUnitUnmarshaller defines an optional interface a Source can implement | ||
| // to support units coming from an external source. | ||
| type SourceUnitUnmarshaller interface { | ||
| UnmarshalSourceUnit(data []byte) (SourceUnit, error) |
There was a problem hiding this comment.
Since these returned SourceUnit objects will be opaque to callers, how do they get used? Will they just be sent back to the source to either marshal or consume?
There was a problem hiding this comment.
Yes, most likely they'll be provided to the caller to be consumed. Marshalling can happen without the Source doing it for us.
It's an extra step the engine will have to take to scan units marshalled and stored in an external source.
There was a problem hiding this comment.
per huddle: they won't be completely opaque, because the source unit manager will be recording each source unit's id and using it to plan/report on things
rosecodym
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the interfaces for sources to begin supporting enumeration/scanning with
SourceUnits.For example usage, see this commit.