Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add JSON tags to job metrics #2114

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[chore] Add JSON tags to job metrics #2114

merged 1 commit into from
Nov 17, 2023

Conversation

mcastorina
Copy link
Collaborator

Description:

Add JSON tags to metrics objects, and change time.Time to *time.Time so omitempty works properly.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@mcastorina mcastorina requested a review from a team as a code owner November 16, 2023 23:27
@mcastorina mcastorina merged commit 39a603d into main Nov 17, 2023
9 checks passed
@mcastorina mcastorina deleted the chore-time-pointers branch November 17, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcastorina @ahrav