Convert Shortcut detector to tri-state verification #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
force-pushed
the
fix/shortcut-detector
branch
3 times, most recently
from
28c3c57
to
8d0b2c9
Compare
ahrav
approved these changes
Dec 17, 2023
rgmz
force-pushed
the
fix/shortcut-detector
branch
from
8d0b2c9
to
ed8bb86
Compare
rgmz
force-pushed
the
fix/shortcut-detector
branch
from
ed8bb86
to
bc2d663
Compare
haraldh
pushed a commit
to matter-labs/vault-auth-tee
that referenced
this pull request
Dec 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [trufflesecurity/trufflehog](https://togithub.com/trufflesecurity/trufflehog) | action | patch | `v3.63.4` -> `v3.63.5` | --- ### Release Notes <details> <summary>trufflesecurity/trufflehog (trufflesecurity/trufflehog)</summary> ### [`v3.63.5`](https://togithub.com/trufflesecurity/trufflehog/releases/tag/v3.63.5) [Compare Source](https://togithub.com/trufflesecurity/trufflehog/compare/v3.63.4...v3.63.5) #### What's Changed - \[chore] Prevent panic when ChunkError has a nil Unit by [@​mcastorina](https://togithub.com/mcastorina) in [trufflesecurity/trufflehog#2227 - \[feat] - Make skipping binaries configurable by [@​ahrav](https://togithub.com/ahrav) in [trufflesecurity/trufflehog#2226 - \[chore] Add skip_binaries field to AzureRepos proto message by [@​mcastorina](https://togithub.com/mcastorina) in [trufflesecurity/trufflehog#2232 - Don't run detector tests on forks by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2234 - Update Freshworks verification to check for valid JSON response by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2212 - Enhance HuggingFace extra data by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2222 - Convert Shortcut detector to tri-state verification by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2211 - add secretID to chunk by [@​ahrav](https://togithub.com/ahrav) in [trufflesecurity/trufflehog#2242 - fix(deps): update module golang.org/x/crypto to v0.17.0 \[security] by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2243 **Full Changelog**: trufflesecurity/trufflehog@v3.63.4...v3.63.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/vault-auth-tee). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This converts the Shortcut detector to use tri-state verification. It also (implicitly) removes
FromDatareturning errors directly, which periodically caused issues scanning chunks.Checklist:
make test-community)?make lintthis requires golangci-lint)?