This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: update equality checks for replacement transactions to prevent erroneous underpriced errors #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use maxPriorityFeePerGas, maxFeePerGas, and gasPrice to check if a transaction is an eligible replacement. fix bug to include replacement transaction EQUAL to price bump
davidmurdoch
suggested changes
Nov 24, 2021
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
…e/ganache into fix/replacement-transactions
davidmurdoch
changed the title
davidmurdoch
approved these changes
Nov 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where replacement transactions with
effectiveGasPrice = previousTxGasPrice + (previousTxGasPrice * priceBumpPercentare not viable replacements (essentially a<to a<=). This edge case is actually pretty common because metamasks "Cancel transaction" functionality sets to this exact value.Updates logic to verify replacement transactions so that
maxFeePerGasandmaxPriorityFeePerGasare both always checked against the previous transaction if the transactions have those fields. If not, those fields are defaulted togasPrice. This is in line with geth's implementation.Adds
--miner.priceBumpoption to make the priceBump requirement configurable.