Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: update equality checks for replacement transactions to prevent erroneous underpriced errors #1650

Merged
merged 9 commits into from
Nov 24, 2021
Merged

fix: update equality checks for replacement transactions to prevent erroneous underpriced errors #1650

merged 9 commits into from
Nov 24, 2021

Commits on Nov 24, 2021

  1. add miner.priceBump option

    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a775697 View commit details
    Browse the repository at this point in the history

  2. add error for locked transaction

    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a80054f View commit details
    Browse the repository at this point in the history

  3. fix replacement tx logic 

    use maxPriorityFeePerGas, maxFeePerGas, and gasPrice to check if a
transaction is an eligible replacement.

fix bug to include replacement transaction EQUAL to price bump
    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    b87719e View commit details
    Browse the repository at this point in the history

  4. modify test to include extra fail cases

    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    9dacda8 View commit details
    Browse the repository at this point in the history

  5. update comment

    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    5cf26a0 View commit details
    Browse the repository at this point in the history

  6. add back comment

    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    4219a82 View commit details
    Browse the repository at this point in the history

  7. Fix/improve error message 

    Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
    @MicaiahReid @davidmurdoch
    MicaiahReid and davidmurdoch committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    bc85afa View commit details
    Browse the repository at this point in the history

  8. allow string for priceBump option

    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    8fb97fb View commit details
    Browse the repository at this point in the history

  9. Merge branch 'fix/replacement-transactions' of github.com:trufflesuit… 

    …e/ganache into fix/replacement-transactions
    @MicaiahReid
    MicaiahReid committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    cd3eb0f View commit details
    Browse the repository at this point in the history