This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix estimateGas bug when basefee > defaultTransactionGasLimit #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gasLimit for an estimateGas call was set to the defaultTransactionGasLimit of 90000 gas. This would cause ethereumjs-vm runCall to throw the error 'base fee exceeds gas limit'. By setting the gasLimit to the block gas limit, this allows use to correctly estimate gas for tx's where the basefee > gasLimit, such as when deploying a contract.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gasLimit for an estimateGas call was set to the
defaultTransactionGasLimit of 90000 gas. This would cause
ethereumjs-vm runCall to throw the error 'base fee exceeds
gas limit'.
By setting the gasLimit to the block gas limit, this allows use to
correctly estimate gas for tx's where the basefee > gasLimit, such as
when deploying a contract.