This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feat: add `eth_feeHistory` JSON-RPC endpoint #3351

Merged

tenthirtyone merged 140 commits into develop from feat/eth_feeHistory

Oct 21, 2022

Contributor

tenthirtyone commented Jul 12, 2022 •

edited by davidmurdoch

Loading

Adds eth_feeHistory to the JSON-RPC API. This endpoint returns gas used, baseFeePerGas, and effective reward by array of percentages accounting for gas used for a range of blocks.

Fixes: #1470

tenthirtyone added 21 commits

June 30, 2022 11:58


          feat: eth_feeHistory JSON RPC endpoint

b513a4e


          add feeHistory type to api-types.ts

c25378c


          wire in stubbed endpoint with return type

f7e846c


          document api endpoint

d7e61cc


          document FeeHistoryResult type

49dd159


          get a block

4161ad1


          add number to param type for blockNumber in getRawByBlockNumber

523d81b


          update api-types to account for empty array

396fef4


          get oldestBlock, gasUsed, baseFeePerGas for range

c8d04e3


          convert bigint to hexstring

a61278a


          calc next block baseFeePerGas

1722dee


          basic unit tests

b9d5712


          only calcNextBlock if EIP1559 is activated by checking for baseGasFee

e84716f


          fix gasUsed precision calc, get tx receipts

bf792c9


          stubbed rewardPercentiles


          remove currentBlock check, MAX SAFE INT check stubbed

b8158e3


          comparable results to infura on mainnet forking without reward

2d2eac7


          clean up logs

0ad49cf


          api numbers comparable to infura for block gas used.

13402f9


          handle pre-eip 1559 blocks

1b2bba4


          reduce bigint converts

359066a

tenthirtyone requested a review from jeffsmale90

July 12, 2022 07:26

tenthirtyone added 2 commits

July 12, 2022 02:28


          pretend like this wasnt in the PR

9ac7e39


          update api types comment

8b698a7

jeffsmale90 suggested changes

View reviewed changes

Contributor

jeffsmale90 left a comment

I've focussed on the Quantity usage, I'll jump back on this to really understand the rest once it's out of draft, or if you want me to take another look before then, lmk.

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

tenthirtyone added 5 commits

July 14, 2022 15:57


          remove Quantity abuses. comparable infura results for range, and empt…

276faf1

…y reward percentile. Require 3 args


          handle pre-london, post-london eip-1559 ranges

6975dd9


          unit tests for params

21bebae


          code coverage for baseFeePerGas

ae02d7a


          account for mainnet forking baseFeePerGas

3a3233a

MicaiahReid approved these changes

View reviewed changes

tenthirtyone and others added 4 commits

October 11, 2022 11:07


          Update src/chains/ethereum/ethereum/src/api.ts

b89b357

Co-authored-by: jeffsmale90 <6363749+jeffsmale90@users.noreply.github.com>


          Update src/chains/ethereum/ethereum/src/api.ts

09a5f32

Co-authored-by: jeffsmale90 <6363749+jeffsmale90@users.noreply.github.com>


          min/max reduce util

6fbf0c5


          Merge remote-tracking branch 'origin/develop' into feat/eth_feeHistory

6a12230

tenthirtyone requested review from jeffsmale90 and davidmurdoch

October 11, 2022 22:35

jeffsmale90 reviewed

View reviewed changes

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

tenthirtyone and others added 3 commits

October 12, 2022 09:23


          Update src/chains/ethereum/ethereum/src/api.ts

6c3484c

Co-authored-by: jeffsmale90 <6363749+jeffsmale90@users.noreply.github.com>


          fix a type

4cc0281


          simplify Number cast

0050c60

tenthirtyone requested a review from jeffsmale90

October 12, 2022 16:31

jeffsmale90 approved these changes

View reviewed changes

davidmurdoch reviewed

View reviewed changes

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved


          Update src/chains/ethereum/ethereum/src/api.ts

581bf90

Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>

davidmurdoch mentioned this pull request

Investigate sorting optimization in eth_feeHistory #3804

Open

davidmurdoch suggested changes

View reviewed changes

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/packages/utils/src/utils/min-max.ts Show resolved Hide resolved

src/packages/utils/src/utils/min-max.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

tenthirtyone added 5 commits

October 20, 2022 17:18


          add @eip tag to jsdoc, rebuild docs

3bebc11


          remove unnecessary async

cf4a178


          update jsdoc for min-max

240955f


          Merge remote-tracking branch 'origin/feat/eth_feeHistory' into feat/e…

d940da9

…th_feeHistory


          Merge remote-tracking branch 'origin/develop' into feat/eth_feeHistory

4c812f9

tenthirtyone requested a review from davidmurdoch

October 21, 2022 16:01

davidmurdoch suggested changes

View reviewed changes

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved


          Update src/chains/ethereum/ethereum/src/api.ts

f998c63

Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>

davidmurdoch approved these changes

View reviewed changes

Member

davidmurdoch left a comment

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

tenthirtyone merged commit aca0889 into develop

tenthirtyone deleted the feat/eth_feeHistory branch

October 21, 2022 19:09

gitpoap-bot bot commented Oct 21, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ganache Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

davidmurdoch mentioned this pull request

GitPOAP has notified same user at least 4 times on one repo this year gitpoap/gitpoap-bot#38

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.