Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitPOAP has notified same user at least 4 times on one repo this year #38

Open
davidmurdoch opened this issue Dec 19, 2022 · 5 comments

Comments

@davidmurdoch
Copy link
Contributor

trufflesuite/ganache#3890
trufflesuite/ganache#4003
trufflesuite/ganache#3351
trufflesuite/ganache#4003

Maybe something weird is going on in their account?

Or maybe they haven't claimed and this is intended behavior of the GitPOAP bot? If that's the case, it's a bit annoying -- as the user might not want to (or can't) claim, and this notification comes off as nagging.

@tenthirtyone
Copy link

tenthirtyone commented Dec 19, 2022

trufflesuite/ganache#4064

  • Five times

Twice today

@peebeejay
Copy link
Contributor

we are on it - we'll be changing this behavior to make it less nagging.

definitely apologize for the annoyance on this - i too don't like getting notified too many times for the same thing.

cc @burz ~ are the changes released?

@burz
Copy link
Contributor

burz commented Dec 19, 2022

Hey all, we've just now updated the bot so it won't re-notify a user for PRs that were merged, unless they were explicitly tagged by an owner of the repository. Essentially this means that a user will be notified the first time they become eligible, but won't be notified again on additional merged PRs even if they haven't completed the claim.

@davidmurdoch
Copy link
Contributor Author

Awesome! Thanks so much!

@peebeejay
Copy link
Contributor

thank you for the valuable feedback btw!

all feedback is a gift 🎁 in our eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants