This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: remove Promise.allSettled shim
#4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
approved these changes
Dec 8, 2022
davidmurdoch
reviewed
Dec 8, 2022
src/packages/core/src/server.ts
Outdated
| @@ -7,14 +7,6 @@ import { | |||
|
|
|||
| import allSettled from "promise.allsettled"; | |||
There was a problem hiding this comment.
The promise.allsettled package itself should be removed.
davidmurdoch
suggested changes
Dec 8, 2022
|
Looks like it doesn't work in Node v12.0.0. Let's wait on this until after the-merge is in |
MicaiahReid
force-pushed
the
chore/allsettled-shim
branch
from
4516f15
to
e1b2930
Compare
|
@tenthirtyone let's merge this one after the merge is released (which should be later today). |
jeffsmale90
reviewed
Dec 19, 2022
@jeffsmale90 - should have been taken care of in 6268b36 |
davidmurdoch
approved these changes
Dec 19, 2022
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ganache Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was TODO'd to be removed if we bumped
typescriptto4.2.3+