This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: add "EADDRINUSE" as code to server Error
#4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
commented
Dec 15, 2022
davidmurdoch
requested review from
jeffsmale90,
MicaiahReid and
tenthirtyone
davidmurdoch
commented
Dec 16, 2022
davidmurdoch
force-pushed
the
fix/EADDRINUSE
branch
2 times, most recently
from
f82c064
to
3a01b6f
Compare
jeffsmale90
approved these changes
Dec 19, 2022
Co-authored-by: Jeff Smale <6363749+jeffsmale90@users.noreply.github.com>
davidmurdoch
force-pushed
the
fix/EADDRINUSE
branch
from
5e0eede
to
eadd8ab
Compare
tenthirtyone
approved these changes
Jan 4, 2023
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Ganache Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
codeproperty related to the error"listen EADDRINUSE: address already in use { address }"to "EADDRINUSE", making detecting this kind of "address in use" error programmatically much easier and straightforward. This property existed in Ganache v6 and earlier and was removed in v7.0.0 in error.Previously:
{ "message": "listen EADDRINUSE: address already in use 127.0.0.1:5001" }Now:
{ "code": "EADDRINUSE", "message": "listen EADDRINUSE: address already in use 127.0.0.1:5001" }Fixes #4020