This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Improved breakpoint functionality #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1431
💛 - Coveralls |
gnidan
approved these changes
Sep 27, 2018
| else | ||
| { | ||
| return this.dispatch(controller.removeBreakpoint(breakpoint)); | ||
| } |
There was a problem hiding this comment.
I kinda think this should be two separate methods
| { | ||
| config.logger.log(`Breakpoint removed at ${locationMessage}.`); | ||
| } | ||
| return; |
There was a problem hiding this comment.
Note for later: you might consider splitting this up into multiple functions that could live in debug-utils. But no need to do it now; I think you'll find yourself naturally wanting that in the course of any follow-up work.
| splitArgs=cmd.trim().split(/ +/).slice(1); | ||
| debug("splitArgs %O",splitArgs); | ||
|
|
||
| //warning: this bit *alters* cmd! |
There was a problem hiding this comment.
isn't that kind of annoying?
gnidan
reviewed
Sep 27, 2018
| else | ||
| { | ||
| config.logger.log(`Breakpoint removed at ${locationMessage}.`); | ||
| } |
There was a problem hiding this comment.
Ah so I just tried this feature out and realized something that might be nice: an extra blank line after these added/removed messages.
This looks a bit cluttered:
debug(develop:0x91c817a1...)> b SquareLib:5
Breakpoint added at line 5 in SquareLib.sol.
debug(develop:0x91c817a1...)> b +10
Breakpoint added at line 23.
debug(develop:0x91c817a1...)> B +10
Breakpoint removed at line 23.
Compared with:
debug(develop:0x91c817a1...)> b SquareLib:5
Breakpoint added at line 5 in SquareLib.sol.
debug(develop:0x91c817a1...)> b +10
Breakpoint added at line 23.
debug(develop:0x91c817a1...)> B +10
Breakpoint removed at line 23.
gnidan
reviewed
Sep 28, 2018
| }; | ||
|
|
||
| session.continueUntil(breakpoint); | ||
| session.setOrClearBreakpoint(breakpoint,true); |
gnidan
reviewed
Sep 28, 2018
| let breakpointStopped = false; | ||
|
|
||
| session.setOrClearBreakpoint(breakpoint,true); |
…e breakpoint command from the add breakpoint command.
…r new breakpoint code.
haltman-at
force-pushed
the
breakpoints
branch
from
f788168
to
737291b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch expands the functionality of breakpoints as requested in #1276. Breakpoints can now be set on a line of the user's choice in a source file of their choice; they can also be set at the current location as before. Breakpoints are no longer toggled with
bbut rather set withband cleared withB. A breakpoint set withbwith no arguments is set at the current location; this is the current location within the line, like the old breakpoints. Breakpoints may also be set at a given line (including in another source file), which may also be specified relative to the current line; these breakpoints will stop execution at the first encountered location within that line. Breakpoints in another source file need only have enough of the filename specified to unambiguously identify it; if what's given is ambiguous, the user will be prompted with a list of possibilities.This branch does not include expanded functionality for
?.