This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Update truffle-hdwallet-provider (docs & codebase) #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refactored the code to make it easier to reason about in the future. Also documented the Web3 shim. |
gnidan
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
truffle-hdwallet-provider's documentation (clarifies current web3.js compatibility version requirement & updates truffle project example to match infura's updated API), upgradesweb3-engine-providerdep to latest, & adds a shim to supportsendAsyncmethods. Also addsweb3@1.0.0-beta.37as a dependency to temporarily relieve friction between users & current web3 compatibility issues.Potentially resolves #1746, #1643, #852, & #1874.