This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Declutter @truffle/interface-adapter #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move shim stuff into lib/shim/ - Move lib/web3-shim to lib/shim/index - Move overloads lib/*-overloads to lib/shim/overloads/* - Move adapter stuff into lib/adapter/ - Move lib/interface-adapter.ts to lib/adapter/index.ts - Move lib/interface-adapter/types/index.d to lib/adapter/types - Rename lib/interface-adapter to lib/adapter (better autocomplete) - Move lib/web3-interface-adapter to lib/adapter/web3
- Replace `new InterfaceAdapter` with `createInterfaceAdapter` - Remove setProvider and setNetworkType from interface - Recreate interface adapter in @truffle/contract instead of mutating
- Move InterfaceAdapter to ./types - (also) Export all types in package root - Remove Web3InterfaceAdapter's setProvider method (not part of iface) - Define Web3InterfaceAdapterOptions explicitly, not related to shim - Update Web3InterfaceAdapter class to implement InterfaceAdapter
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createInterfaceAdapterfunction in place of class constructorlib/shim/andlib/adapter/