This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix: Remove problematic debugging output #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note: I've made a commit to turn on Colony tests unconditionally on this branch. I'll revert that commit once the Colony tests pass.) |
|
OK, the Colony tests passed this time so I'm reverting that commit! (Two other tests failed but for stupid reasons, and anyway those ones are always run anyway.) |
…is branch" This reverts commit 85c6f5d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR, #2851, seems to be causing the Colony tests to fail. The reason for this seems to be some debugging output I left in that foolishly includes some dereferencing (which, obviously, can fail). So, I'm just deleting that debugging output.