Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Upgrade @ethereumjs/common to ^2.4.0 and @ethereumjs/tx to ^3.3.0, again #4273

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

eggplantzzz
Copy link
Contributor

@eggplantzzz eggplantzzz commented Aug 19, 2021

📵 Do not merge this PR until October when support for Node.js version 10 is discontinued.

This PR updates @ethereumjs/common and @ethereumjs/tx in @truffle/hdwallet-provider.

Reverts #4271

@agro1986
Copy link

Do not merge this PR until October when support for Node.js version 10 is discontinued.

It seems that this PR is needed for EIP-1559 transactions. So no London tx support until at least 1 more month?

@eggplantzzz eggplantzzz mentioned this pull request Aug 24, 2021
@davidmurdoch davidmurdoch changed the title Revert "Revert "Upgrade @ethereumjs/common to ^2.4.0 and @ethereumjs/tx to ^3.3.0"" Upgrade @ethereumjs/common to ^2.4.0 and @ethereumjs/tx to ^3.3.0, again Aug 25, 2021
@eggplantzzz
Copy link
Contributor Author

Hey @agro1986, I just published @truffle/hdwallet-provider@eip1559-beta. This dist tag release includes the work from #4273 as well as the work in this PR.

If you get a chance to try this and have feedback then let us know!

@eggplantzzz eggplantzzz force-pushed the revert-4271-revert-4263-bump-common branch from 25285a9 to ef4d25c Compare October 6, 2021 19:21
@cds-amal cds-amal self-requested a review October 6, 2021 20:55
Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had question on preexisting code, so I don't think it should hold a merge.

packages/hdwallet-provider/src/index.ts Show resolved Hide resolved
@eggplantzzz eggplantzzz merged commit 44028dc into develop Oct 6, 2021
@eggplantzzz eggplantzzz deleted the revert-4271-revert-4263-bump-common branch October 6, 2021 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants