Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

support eip-1559 #4276

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Conversation

XWJACK
Copy link
Contributor

@XWJACK XWJACK commented Aug 23, 2021

No description provided.

@eggplantzzz
Copy link
Contributor

eggplantzzz commented Aug 24, 2021

Thanks for the PR @XWJACK! We probably have to wait until Ganache fully supports 1559 before releasing this, but we also have to wait until October as well. That is because the updated versions of the @ethereumjs libraries (made in #4273) aren't compatible with Node 10 as they require at least 12-something. Truffle will stop supporting Node 10 in October. By then Ganache might have the required updates to release these PRs :)

@eggplantzzz
Copy link
Contributor

I just published @truffle/hdwallet-provider@eip1559-beta. This dist tag release includes the work in this PR as well as the work in #4273.

If you get a chance to try this and have issues then let us know!

@eggplantzzz eggplantzzz force-pushed the revert-4271-revert-4263-bump-common branch from 25285a9 to ef4d25c Compare October 6, 2021 19:21
@eggplantzzz
Copy link
Contributor

So I rebased #4273 and we're going to merge it soon. @XWJACK any chance you can resolve the conflict? I'm going to try and make sure hdwallet-provider is 1559 compliant over the next few weeks. I think there may have been some more work to do on this front?

@eggplantzzz eggplantzzz deleted the branch trufflesuite:develop October 6, 2021 21:02
@eggplantzzz eggplantzzz closed this Oct 6, 2021
@eggplantzzz eggplantzzz reopened this Oct 7, 2021
@eggplantzzz eggplantzzz changed the base branch from revert-4271-revert-4263-bump-common to develop October 7, 2021 21:25
@cds-amal
Copy link
Member

cds-amal commented Oct 8, 2021

Hi @XWJACK would it be possible to undo the merge and do a rebase against develop instead?

@eggplantzzz
Copy link
Contributor

Thanks @XWJACK, we're making progress on this right now!

@eggplantzzz eggplantzzz self-requested a review October 29, 2021 14:27
Copy link
Contributor

@eggplantzzz eggplantzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @XWJACK, @eggplantzzz !

@eggplantzzz
Copy link
Contributor

This will need a version bump once we get the changes to @trufflesuite/we3-provider-engine released.

@eggplantzzz eggplantzzz merged commit 2b07ec5 into trufflesuite:develop Nov 3, 2021
@eggplantzzz
Copy link
Contributor

Thanks again for this @XWJACK!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants