-
Notifications
You must be signed in to change notification settings - Fork 2.3k
support eip-1559 #4276
support eip-1559 #4276
Conversation
Thanks for the PR @XWJACK! We probably have to wait until Ganache fully supports 1559 before releasing this, but we also have to wait until October as well. That is because the updated versions of the @ethereumjs libraries (made in #4273) aren't compatible with Node 10 as they require at least 12-something. Truffle will stop supporting Node 10 in October. By then Ganache might have the required updates to release these PRs :) |
I just published @truffle/hdwallet-provider@eip1559-beta. This dist tag release includes the work in this PR as well as the work in #4273. If you get a chance to try this and have issues then let us know! |
25285a9
to
ef4d25c
Compare
Hi @XWJACK would it be possible to undo the merge and do a rebase against develop instead? |
0f212cb
to
20c456a
Compare
20c456a
to
a7e8063
Compare
Thanks @XWJACK, we're making progress on this right now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @XWJACK, @eggplantzzz !
This will need a version bump once we get the changes to @trufflesuite/we3-provider-engine released. |
Thanks again for this @XWJACK! |
No description provided.