Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Reject SolidityAST contracts verified on Etherscan #6082

Merged
merged 1 commit into from Jun 9, 2023
Merged

Conversation

haltman-at
Copy link
Contributor

@haltman-at haltman-at commented Jun 9, 2023

As of Solidity 0.8.20, it's now possible to use the Solidity compiler in a mode where, instead of passing language: "Solidity" or language: "Yul", you pass language: "SolidityAST", and put in the AST of what you want compiled (it's the long-awaited companion to the stop-after-parsing option).

I got worried about the possibility that Etherscan might allow verifying input in this form. I haven't actually yet tested whether it does, I intend to test that later. But I thought it would be good to put in a bit of defensive coding against that possibility right now, since there's no way we can reasonably handle it (at least, not quickly right now).

Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@haltman-at haltman-at merged commit eaadc7e into develop Jun 9, 2023
10 checks passed
@haltman-at haltman-at deleted the tree-defense branch June 9, 2023 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants