Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: fix various 8.0.0 issues #2820

Merged
merged 29 commits into from Mar 21, 2024
Merged

fix!: fix various 8.0.0 issues #2820

merged 29 commits into from Mar 21, 2024

Conversation

jpandersen87
Copy link
Contributor

@jpandersen87 jpandersen87 commented Mar 15, 2024 •
edited

Summary

This PR fixes some issues with the 8.0.0 release. It also addresses the issue of focus-trap-react and jsdom by requiring users to add focus-trap-react as a dependency to their projects with documentation on the issue so that they can ensure unit tests rendering Modal do not fail.

  • add css files to package.json exports (credit to mdmower-csnw)
  • add jest-dom to tsconfig types
  • add focus-trap-react as peer dependency and exclude from library bundle
  • update documentation to explain the focus-trap-react issue and to install focus-trap-react with react-uswds
  • update dependencies
  • updates and fixes presented yarn version (fixes errors when adding library via git)
  • adds some protection against undefined properties in dangerfile

Related Issues or PRs

How To Test

  • Use this branch for the version of react-uswds in your project
  • Verify that you can successfully import the index.css and uswds.css files in code
  • Verify that you can mock the focus-trap-react library to prevent errors when rendering Modal in unit tests

@mdmower-csnw
Allow importing css from npm package
c76f61d 
Let projects import lib/index.css and lib/uswds.css by adding them to
conditional exports in package.json.
@jpandersen87 jpandersen87 requested review from a team as code owners March 15, 2024 22:12
@jpandersen87 jpandersen87 changed the title fix: fix various 8.0.0 issues fix!: fix various 8.0.0 issues Mar 15, 2024
@jpandersen87 jpandersen87 mentioned this pull request Mar 18, 2024
Merged
@jpandersen87 jpandersen87 marked this pull request as draft March 18, 2024 17:42
@jpandersen87
Copy link
Contributor Author

Temporarily moving to draft to fix git history

werdnanoslen and others added 22 commits March 18, 2024 12:46
@werdnanoslen @shkeating @jpandersen87
fix: Added hook to combobox for when options change (trussworks#2715)
df3595f 
Co-authored-by: Shauna Keating <59394696+shkeating@users.noreply.github.com>
@dependabot @jpandersen87
build(deps-dev): Bump @typescript-eslint/parser from 6.21.0 to 7.1.1 (t…
208a69b 
…russworks#2813)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump @laynezh/vite-plugin-lib-assets from 0.5.20 to …
7eca3e6 
…0.5.21 (trussworks#2814)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump eslint-plugin-storybook from 0.6.15 to 0.8.0 (t…
7f73405 
…russworks#2816)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump yarn from 1.22.21 to 1.22.22 (trussworks#2817)
97b86c1 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump eslint-plugin-vitest from 0.3.22 to 0.3.25 (tru…
b6b0f35 
…ssworks#2818)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@jpandersen87
fix 8.0.0 issues
fbc7545 
- add css files to package.json exports
- add jest-dom to tsconfig types
- add focus-trap-react as peer dependency
- update dependencies
- migrated to sb 8.0
@jpandersen87
update yarn 1.22.x version
abdffd6
@jpandersen87
make react-focus-trap external
f865776
@jpandersen87
documentation on react-focus-trap in tests
d9a05b5 
- explanation of issue
- update install instructions to include react-focus-trap
@jpandersen87
fix typo
fbb4c22
@jpandersen87
set sb back to 7.x version
2be696e
@werdnanoslen @jpandersen87
docs: added docs for breaking changes and using withDeprecationWarning (
3a161c4 
trussworks#2763)
@jpandersen87
fix sb dep versions
1e100f1
@jpandersen87
revert uswds
437c6f6
@jpandersen87
fix lockfile
d97665a
@dependabot @jpandersen87
build(deps-dev): Bump vitest and @vitest/coverage-istanbul (trusswork…
b81cf18 
…s#2821)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump eslint-plugin-vitest from 0.3.25 to 0.3.26 (tru…
acd6a56 
…ssworks#2823)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump @storybook/blocks from 7.6.17 to 8.0.0 (trusswo…
bc83c32 
…rks#2824)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump vite from 5.1.5 to 5.1.6 (trussworks#2825)
f7a65c4 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump @typescript-eslint/eslint-plugin from 7.1.1 to …
c037c43 
…7.2.0 (trussworks#2826)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@dependabot @kodiakhq @jpandersen87
build(deps-dev): Bump stylelint-config-sass-guidelines from 11.0.0 to…
81406ca 
… 11.1.0 (trussworks#2831)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@jpandersen87 jpandersen87 marked this pull request as ready for review March 18, 2024 17:55
@jpandersen87
Copy link
Contributor Author

Rebased off of @mdmower-csnw 's css branch to ensure he is credited.

rswerve
rswerve previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@rswerve rswerve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was tested by someone on our project who reported it didn't break anything. @werdnanoslen I'm approving 👍

werdnanoslen
werdnanoslen reviewed Mar 21, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
werdnanoslen
werdnanoslen approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@werdnanoslen werdnanoslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks again for the fixes

@werdnanoslen werdnanoslen merged commit e05061e into trussworks:main Mar 21, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
Merged
@jpandersen87 jpandersen87 deleted the 8.0.0-bugs branch March 21, 2024 19:20
@emyl3 emyl3 mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werdnanoslen werdnanoslen werdnanoslen approved these changes

@rswerve rswerve Awaiting requested review from rswerve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpandersen87 @werdnanoslen @rswerve @mdmower-csnw