feat: changed template links to buttons #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werdnanoslen
requested review from
gidjin,
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
|
Happo diff is due to changing to a button instead of link. While not necessarily intended, it doesn't meaningfully affect the story |
|
only thing I noticed of note, is that the link under the form field is getting kicked down and it does not match what the component looks like in its USWDS original state. I would suggest removing some of the padding/margin from the top to put it back to position. |
|
Fixed. The very slight (like 1-2px) happo diffs I self-approved seem to be from changes to the uswds class, as it's otherwise implemented exactly the same as the source. |
haworku
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed links to buttons in signin templates.
Related Issues or PRs
Resolves #2508
How To Test
Open the signin 'form' template and signin 'page' template
Screenshots (optional)