Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changed template links to buttons #2526

Merged
merged 9 commits into from
Oct 5, 2023
Merged

feat: changed template links to buttons #2526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1961371
changed template links to buttons
werdnanoslen Jul 25, 2023
c0ee754
Merge branch 'main' into an-password-2508
werdnanoslen Jul 31, 2023
2115816
Merge branch 'main' into an-password-2508
werdnanoslen Aug 7, 2023
7ebc0aa
Merge branch 'main' into an-password-2508
werdnanoslen Sep 8, 2023
c6a62ae
Merge branch 'main' into an-password-2508
brandonlenz Sep 29, 2023
722fe8e
Merge branch 'main' into an-password-2508
werdnanoslen Sep 29, 2023
6f9c326
Merge branch 'main' into an-password-2508
shkeating Oct 4, 2023
d9d21af
replaced Button component with simple button
werdnanoslen Oct 5, 2023
9f9d03b
replaced Button component with simple button
werdnanoslen Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 19 additions & 23 deletions src/components/forms/Form/Form.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,18 +236,16 @@ export const signInForm = (): React.ReactElement => {
name="password-sign-in"
type={showPassword ? 'text' : 'password'}
/>
<p className="usa-form__note">
<a
title="Show password"
href="javascript:void(0);"
className="usa-show-password"
aria-controls="password-sign-in"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide password' : 'Show password'}
</a>
</p>
<button
title="Show password"
type="button"
className="usa-show-password"
aria-controls="password-sign-in"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide password' : 'Show password'}
</button>

<Button type="submit">Sign in</Button>
<p>
Expand Down Expand Up @@ -290,17 +288,15 @@ export const passwordResetForm = (): React.ReactElement => {
name="confirmPassword"
type={showPassword ? 'text' : 'password'}
/>
<p className="usa-form__note">
<a
href="javascript:void(0);"
className="usa-show-multipassword"
aria-controls="newPassword confirmPassword"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide my typing' : 'Show my typing'}
</a>
</p>
<button
type="button"
className="usa-show-password"
aria-controls="newPassword confirmPassword"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide my typing' : 'Show my typing'}
</button>

<Button type="submit">Reset password</Button>
</Fieldset>
Expand Down
22 changes: 10 additions & 12 deletions src/stories/templates/createaccount.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,18 +204,16 @@ export const CreateAccount = (): React.ReactElement => {
required={true}
/>

<p className="usa-form__note">
<a
title="Show password"
href="javascript:void(0);"
className="usa-show-password"
aria-controls="password-create-account password-create-account-confirm"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide password' : 'Show password'}
</a>
</p>
<button
title="Show password"
type="button"
className="usa-show-password"
aria-controls="password-create-account password-create-account-confirm"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide password' : 'Show password'}
</button>

<Label htmlFor="password-create-account-confirm">
Re-type password{' '}
Expand Down
22 changes: 10 additions & 12 deletions src/stories/templates/signin.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,18 +165,16 @@ export const SignIn = (): React.ReactElement => {
required={true}
/>

<p className="usa-form__note">
<a
title="Show password"
href="javascript:void(0);"
className="usa-show-password"
aria-controls="password-create-account password-create-account-confirm"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide password' : 'Show password'}
</a>
</p>
<button
title="Show password"
type="button"
className="usa-show-password"
aria-controls="password-create-account password-create-account-confirm"
onClick={(): void =>
setShowPassword((showPassword) => !showPassword)
}>
{showPassword ? 'Hide password' : 'Show password'}
</button>

<Button type="submit">Sign in</Button>

Expand Down
Loading