feat: parametrized StepIndicator strings #2707
Conversation
| @@ -16,6 +16,8 @@ type StepIndicatorProps = { | |||
| HTMLHeadingElement | |||
| > | |||
| headingLevel: HeadingLevel | |||
| stepText?: string | |||
There was a problem hiding this comment.
If there are more of these, would it be better to do an object with multiple entries?
text: { step?: string, of?: string }
That way we can extend without adding loads more props?
There was a problem hiding this comment.
These are the only two strings on the top-level component, so would it still be beneficial to put it in such an object?
The other strings are on the StepIndicatorStep sub-component, which could use such a treatment, but I don't think we have that pattern on other components (yet) and wanted to keep this PR tight enough that we can unblock the project requirement.
There was a problem hiding this comment.
Okay no worries, that works. Lemme test.
| <StepIndicator | ||
| headingLevel="h2" | ||
| ofText={args.ofText} | ||
| stepText={args.stepText}> | ||
| <StepIndicatorStep label="Personal information" status="complete" /> |
There was a problem hiding this comment.
Recommend removing the passed in text in one of the tests so that we can ensure the fallback to english works correctly.
…swds into an-steptranslate-2705
Summary
Parametrized strings in StepIndicator component to allow translation of "Step" and "of" strings.
There are still more English strings hard coded in the StepIndicatorStep subcomponent, as well as other components, but this narrow improvement is to allow for a client project to proceed. I will continue pushing for resources to prioritize an i18n strategy (see #1742)
Related Issues or PRs
Resolves #2705
How To Test
Screenshots (optional)