feat: Add [waci-issuance] bdd tests #627
Conversation
talwinder50
force-pushed
the
issue-595
branch
4 times, most recently
from
a1f547e
to
131f83f
Compare
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 28 28
Lines 4244 4244
=======================================
Hits 3716 3716
Misses 308 308
Partials 220 220
Continue to review full report at Codecov.
|
talwinder50
force-pushed
the
issue-595
branch
from
131f83f
to
fa276a9
Compare
| "options":{ | ||
| "challenge":"508adef4-b8e0-4edf-a53d-a260371c1423", | ||
| "domain":"9rf25a28rs96" | ||
| } |
There was a problem hiding this comment.
Why do need to add options here in config file ?
There was a problem hiding this comment.
Right now we dont have logic support for options, but i do see in the spec we have options, also sudesh mentioned we would need to support this in near future, i can take it out for now and add it back when we will add options support
| return nil, fmt.Errorf("failed to generate presentation with credential application : %w", err) | ||
| } | ||
|
|
||
| return presentationWithCA, nil |
There was a problem hiding this comment.
I see from manifest file that we are asking for PRC data. I am not able to find the place where we are setting it in CredentialApplication. Can you please point it to me ?
There was a problem hiding this comment.
@rolsonquadras i am calling PresentCredentialApplication from afg credential application. This internally calls setCustomfield function
There was a problem hiding this comment.
talwinder50
force-pushed
the
issue-595
branch
2 times, most recently
from
bea9d9a
to
3307906
Compare
partof trustbloc#595 Signed-off-by: talwinder50 <talwinderkaur50@gmail.com>
talwinder50
force-pushed
the
issue-595
branch
from
3307906
to
869218a
Compare
partof #595
Signed-off-by: talwinder50 talwinderkaur50@gmail.com