Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

prepare bootstrap data #19

Closed
DRK3 opened this issue Jul 20, 2020 · 4 comments · Fixed by #40
Closed

prepare bootstrap data #19

DRK3 opened this issue Jul 20, 2020 · 4 comments · Fixed by #40
Assignees
@llorllale
Labels
type: enhancement New feature or request
Milestone
0.1.4

Comments

@DRK3
Copy link
Collaborator

DRK3 commented Jul 20, 2020

No description provided.

@DRK3 DRK3 added the type: enhancement New feature or request label Jul 20, 2020
@DRK3 DRK3 added this to the 0.1.4 milestone Jul 20, 2020
@DRK3 DRK3 self-assigned this Jul 20, 2020
@DRK3 DRK3 mentioned this issue Jul 20, 2020
Closed
@llorllale
Copy link
Contributor

Note: profile == bootstrap data for the web wallet

@DRK3 DRK3 assigned llorllale and unassigned DRK3 Jul 23, 2020
@DRK3
Copy link
Collaborator Author

DRK3 commented Jul 23, 2020 •
edited
Loading

Expected data to be stored in bootstrap data (AKA "profile):

  • SDS server URL
  • User primary vault locations
  • Key Server URL
  • User Key Store IDs

@llorllale llorllale mentioned this issue Jul 23, 2020
Open
@llorllale
Copy link
Contributor

@DRK3 I didn't expect the SDS server URL nor the Key Server URL to be stored with the user's bootstrap data. That can change over time and is in fact configurable no? For sure both should be returned to the user's wallet (along with the rest), but I don't think it should be saved unless I'm missing something here.

llorllale pushed a commit to llorllale/hub-auth that referenced this issue Jul 23, 2020
feat: trustbloc#19 prepare bootstrap data in oidc callback
0c709c8 
Signed-off-by: George Aristy <george.aristy@securekey.com>
@llorllale llorllale mentioned this issue Jul 23, 2020
Merged
@llorllale llorllale changed the title Bootstrap: Add "create profile" endpoint Bootstrap: prepare bootstrap data Jul 23, 2020
@llorllale llorllale changed the title Bootstrap: prepare bootstrap data prepare bootstrap data Jul 23, 2020
@DRK3
Copy link
Collaborator Author

DRK3 commented Jul 24, 2020

@llorllale 👍 You're right - there's no need to save it to the database. You're also correct about it being configurable and could potentially change over time.

llorllale pushed a commit to llorllale/hub-auth that referenced this issue Jul 24, 2020
feat: trustbloc#19 prepare bootstrap data in oidc callback
64d6e61 
Signed-off-by: George Aristy <george.aristy@securekey.com>
llorllale pushed a commit to llorllale/hub-auth that referenced this issue Jul 24, 2020
feat: trustbloc#19 prepare bootstrap data in oidc callback
4dc8535 
Signed-off-by: George Aristy <george.aristy@securekey.com>
llorllale pushed a commit to llorllale/hub-auth that referenced this issue Jul 24, 2020
feat: trustbloc#19 prepare bootstrap data in oidc callback
44f5f2c 
Signed-off-by: George Aristy <george.aristy@securekey.com>
llorllale pushed a commit to llorllale/hub-auth that referenced this issue Jul 24, 2020
feat: trustbloc#19 prepare bootstrap data in oidc callback
d054ff7 
Signed-off-by: George Aristy <george.aristy@securekey.com>
llorllale pushed a commit that referenced this issue Jul 24, 2020
Merge pull request #40 from llorllale/19
38fdc3e 
feat: #19 prepare bootstrap data in oidc callback
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@llorllale llorllale

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
0.1.4
Development

Successfully merging a pull request may close this issue.

feat: #19 prepare bootstrap data in oidc callback llorllale/hub-auth
2 participants
@llorllale @DRK3