This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: #19 prepare bootstrap data in oidc callback #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 85.80% 86.82% +1.01%
==========================================
Files 5 6 +1
Lines 310 334 +24
==========================================
+ Hits 266 290 +24
+ Misses 29 28 -1
- Partials 15 16 +1
Continue to review full report at Codecov.
|
llorllale
force-pushed
the
19
branch
2 times, most recently
from
a2bc98b
to
0c709c8
Compare
llorllale
changed the title
llorllale
commented
Jul 23, 2020
|
|
||
| // Provider mock store provider. | ||
| type Provider struct { | ||
| Stores map[string]storage.Store |
There was a problem hiding this comment.
this mock storage provider was created just for this feature right here
DRK3
suggested changes
Jul 24, 2020
llorllale
force-pushed
the
19
branch
2 times, most recently
from
64d6e61
to
4dc8535
Compare
DRK3
approved these changes
Jul 24, 2020
DRK3
reviewed
Jul 24, 2020
DRK3
reviewed
Jul 24, 2020
DRK3
reviewed
Jul 24, 2020
Signed-off-by: George Aristy <george.aristy@securekey.com>
baha-ai
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19
After the user is redirected back from the OIDC provider, hub-auth will onboard the user in the TrustBloc network (TODO) and redirect to the UI (TODO).
Misc: some HTTP status codes were fixed based on the error scenario
Signed-off-by: George Aristy george.aristy@securekey.com