This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
fix: Update signupText and signinText to logos #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 9 9
Lines 968 968
=======================================
Hits 864 864
Misses 76 76
Partials 28 28
Continue to review full report at Codecov.
|
cmd/auth-rest/startcmd/parameters.go
Outdated
| LogoURL string `yaml:"logoURL"` | ||
| SignUpLogo string `yaml:"signUpLogo"` | ||
| SignInLogo string `yaml:"signInLogo"` | ||
| Order string `yaml:"order"` |
cmd/auth-rest/startcmd/parameters.go
Outdated
| SignInText string `yaml:"signInText"` | ||
| LogoURL string `yaml:"logoURL"` | ||
| SignUpLogo string `yaml:"signUpLogo"` | ||
| SignInLogo string `yaml:"signInLogo"` |
There was a problem hiding this comment.
Can we add prefix URL ? since this is pointing to an url
talwinder50
force-pushed
the
issue-141
branch
from
efa9245
to
9387942
Compare
rolsonquadras
approved these changes
Dec 21, 2021
talwinder50
force-pushed
the
issue-141
branch
from
9387942
to
e1985e3
Compare
sudeshrshetty
approved these changes
Dec 21, 2021
closes trustbloc#141 Signed-off-by: talwinder50 <talwinderkaur50@gmail.com>
talwinder50
force-pushed
the
issue-141
branch
from
e1985e3
to
2b268bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change tested in local wallet
closes #141Signed-off-by: talwinder50 talwinderkaur50@gmail.com