This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
[#1] Switch from dep to go modules #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troyronda
reviewed
May 2, 2019
Makefile
Outdated
| @@ -220,19 +220,19 @@ native: peer orderer configtxgen cryptogen idemixgen configtxlator discover | |||
|
|
|||
| linter: check-deps buildenv | |||
| @echo "LINT: Running code checks.." | |||
| @$(DRUN) $(DOCKER_NS)/fabric-buildenv:$(DOCKER_TAG) ./scripts/golinter.sh | |||
| @$(DRUN) -e GOPROXY=$(GOPROXY) $(DOCKER_NS)/fabric-buildenv:$(DOCKER_TAG) ./scripts/golinter.sh | |||
There was a problem hiding this comment.
Does this imply that each Makefile step is fetching Go modules?
There was a problem hiding this comment.
each makefile step will fetch go module if not exist in mod folder in $GOPATH
There was a problem hiding this comment.
There is another instance in another script.
fqutishat
force-pushed
the
issue1
branch
3 times, most recently
from
12d3df0
to
0984a53
Compare
|
@fqutishat note: |
llorllale
reviewed
May 3, 2019
- remove go dep - remove vendor - add go modules Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
I remove change-id |
llorllale
approved these changes
May 3, 2019
sudeshrshetty
approved these changes
May 3, 2019
|
verify |
1 similar comment
|
verify |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I06d450bbe89822729327162db91118e0b595c17a
Signed-off-by: Firas Qutishat firas.qutishat@securekey.com