chore: Add extra logging for policy selection error #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra logging for policy selection error Closes trustbloc#887 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 89.43% 89.49% +0.05%
==========================================
Files 156 156
Lines 13843 13845 +2
==========================================
+ Hits 12381 12391 +10
+ Misses 901 894 -7
+ Partials 561 560 -1
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Nov 19, 2021
DRK3
reviewed
Nov 19, 2021
| if err != nil { | ||
| return nil, nil, fmt.Errorf("select batch witnesses as per policy: %w", err) | ||
| return nil, nil, fmt.Errorf("select batch witnesses based on witnesses%s, eligible%s, common%s, total[%d], policy[%s]: %w", //nolint:lll |
There was a problem hiding this comment.
Note that the lack of spaces between the words and %s may make this hard to read.
There was a problem hiding this comment.
Please disregard - I see now that they get printed with [] characters which makes them stand out
| if err != nil { | ||
| return nil, nil, fmt.Errorf("select system witnesses as per policy: %w", err) | ||
| return nil, nil, fmt.Errorf("select system witnesses based on witnesses%s, eligible%s, common%s, total[%d], policy[%s]: %w", //nolint:lll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra logging for policy selection error
Closes #887
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com