Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add client for verifying resolution response #894

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

sandrask
Copy link
Contributor

This client will:

  • take resolution response as an input
  • assemble resolution result based on the operations provided in input resolution response
  • compare the input and assembled resolution result

Closes #892

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

This client will:

- take resolution response as an input
- assemble resolution result based on the operations provided in input resolution response
- compare the input and assembled resolution result

Closes trustbloc#892

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #894 (7243e6d) into main (fb4cec0) will decrease coverage by 0.00%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   89.47%   89.47%   -0.01%     
==========================================
  Files         156      156              
  Lines       13848    14000     +152     
==========================================
+ Hits        12391    12527     +136     
- Misses        896      905       +9     
- Partials      561      568       +7     
Impacted Files Coverage Δ
pkg/orbclient/nsprovider/provider.go 100.00% <ø> (ø)
pkg/orbclient/resolveverifier/verifier.go 90.00% <90.00%> (ø)
pkg/protocolversion/versions/v1_0/client/client.go 93.33% <91.66%> (-6.67%) ⬇️
pkg/orbclient/client.go 87.50% <100.00%> (ø)
pkg/orbclient/verprovider/provider.go 100.00% <100.00%> (ø)
...g/protocolversion/clientregistry/clientregistry.go 100.00% <100.00%> (ø)
pkg/observer/pubsub.go 94.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4cec0...7243e6d. Read the comment docs.

@sandrask sandrask merged commit 06845c6 into trustbloc:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add client for verifying resolution response
3 participants