feat: Store VC and retrieve VC using edge client #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create the profile and get the prefix of the ID from the profile issue-47This comment was generated by todo based on a
|
talwinder50
force-pushed
the
issue-9
branch
2 times, most recently
from
b2976c7
to
a0e6ca5
Compare
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 89.6% 90.24% +0.63%
==========================================
Files 5 5
Lines 202 246 +44
==========================================
+ Hits 181 222 +41
- Misses 11 13 +2
- Partials 10 11 +1
Continue to review full report at Codecov.
|
sandrask
reviewed
Jan 23, 2020
| // TODO create the profile and get the prefix of the ID from the profile issue-47 | ||
| id = "https://example.com/credentials/1872" | ||
| // ID is the identifier for the verifiable credential | ||
| ID = "https://example.com/credentials/1872" |
There was a problem hiding this comment.
this is not supposed to be exported, it will be removed anyway
| // ID is the identifier for the verifiable credential | ||
| ID = "https://example.com/credentials/1872" | ||
| // VaultID TODO create the profile and get the prefix of the ID from the profile issue-47 | ||
| VaultID = "Credentials" |
There was a problem hiding this comment.
Why exported? You can add it to profile after rebase.
| } | ||
| svc.registerHandler() | ||
|
|
||
| _, err = svc.client.CreateDataVault(&operation.DataVaultConfiguration{ReferenceID: VaultID}) |
There was a problem hiding this comment.
Should this be done during profile creation?
There was a problem hiding this comment.
@troyronda can you please suggest if its okay to create the data vault during the creation of issuer profile
There was a problem hiding this comment.
I would have thought so.
talwinder50
force-pushed
the
issue-9
branch
2 times, most recently
from
bc615c1
to
41b2260
Compare
talwinder50
force-pushed
the
issue-9
branch
3 times, most recently
from
d340045
to
33c159d
Compare
sandrask
approved these changes
Jan 24, 2020
DRK3
requested changes
Jan 24, 2020
remove the stripping of the string issue-34This comment was generated by todo based on a
|
remove the stripping of the string issue-34This comment was generated by todo based on a
|
closes: trustbloc#9 Signed-off-by: talwinder.kaur <talwinder.kaur@securekey.com>
DRK3
approved these changes
Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9