-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integrations screen #40
Conversation
@zackkatz A note: instead of copying how the modal is implimented in the design /trustedlogin-html-revisions-02/helpdesk-configure . I am going to use this: https://headlessui.dev/react/dialog and make the modal look like the design. Figuring out how to translate the CSS for the modal open/ close to React and also making it accessible is going to be a lot more work then using the component Tailwind built for this. |
Sure, makes sense @Shelob9 |
@zackkatz This isn't done, but is close, see the todos I added to description. I'm done for today. If you have a chance to try this out and can you please let me know what you think:
|
@Shelob9 Looks good as a starting point. A few design issues (I figured this is a Work In Progress), but I figured I should point them out. How should this be opened? According to the design, it should be opened with a Configure button. |
@zackkatz I am not using that "configure" link from the design beacuse that would open the Global settings for Helpscout. There is no such setting. I think this is an artifact of the previous plugin's data structure, which only had one team. This seams to be a constant issue: designs are for the previous data model (one account per plugin, global helpdesk settings) vs current data model: multiple teams, helpdesk settings are part of account settings. The modal in the design has callback URL and secret, those are specific are specific to to a team. I need to add these inputs to the Team UI, there is no design for that. |
@Shelob9 Let's do that. |
@zackkatz Lingering questions:
|
@Shelob9 Don't worry about the modal button design for now. What do you mean by the "green button"? If you mean the "Status: Connected" icon, it should open the connection summary. |
for #32