Added try/catch for format_ips url read logic. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn't available. Fixes system crash during boot.
|
👍 will checkout soon |
|
Sorry about the second commit, I didn't think it would get included by default in the previously created pull request. I have changed the base URL because artillery installed with your repo path which for now is missing the commit e6f54b0 and causes it to crash on my machine on boot every time, I will add a commit range to exclude the commit 0d2d14b from the pull request. |
|
Okay I have reverted my last commit so you can go ahead with the pull request as it will include only the desired commit. |
…added catch for DNS resolving error URLError error code, -2.
Corrected urllib2 error catching code.
trustedsec
pushed a commit
that referenced
this pull request
Aug 18, 2015
Added try/catch for format_ips url read logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added try/catch for HTTPError in case threat intelligence feed page isn't available; Fixes system crash during boot if urllib2 gets a Forbidden 403 (or any other HTTPError). This is only if the user decides during setup to enable script execution on boot.