chore: replace rust-lzma with liblzma #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this is to have an lzma dependency, which supports vendoring.
jcrossley3
reviewed
Jul 11, 2024
| @@ -36,7 +37,8 @@ vendored = [ | |||
| "openssl/vendored", | |||
| # when using a vendored approach, we need to statically link zlib, otherwise we get some strange linker error | |||
| # unresolvable R_AARCH64_ADR_PREL_PG_HI21 relocation against symbol `__stack_chk_guard@@GLIBC_2.17' | |||
| "libz-sys/static" | |||
| "libz-sys/static", | |||
| "liblzma/static", | |||
There was a problem hiding this comment.
Is this change alone sufficient? Would adding this enable rust-lzma to work?
There was a problem hiding this comment.
No, as we need to remove rust-lzma. The build.rs of rust-lzma doesn't support. a vendored version.
helio-frota
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this is to have an lzma dependency, which supports vendoring.