Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: implement backend based on database #77

Merged
merged 2 commits into from
Mar 15, 2024
Merged

refactor: implement backend based on database #77

merged 2 commits into from
Mar 15, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Mar 15, 2024

No description provided.

@ctron
refactor: implement backend based on database
393a2ae 
This also pulls out the generic database logic from Graph and puts it
into the common module. Allowing for other modules accessing the
database without polluting the "graph" module.
helio-frota
helio-frota reviewed Mar 15, 2024
View reviewed changes
server/src/lib.rs
username: "postgres".to_string(),
password: "eggs".to_string(),
host: "localhost".to_string(),
port: 5432,
Copy link
Collaborator

@helio-frota helio-frota Mar 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this part of the port-config is probably related to the github-discussions env/vars etc, not a blocker-to-me)

@jcrossley3 jcrossley3 mentioned this pull request Mar 15, 2024
Closed
bobmcwhirter
bobmcwhirter approved these changes Mar 15, 2024
View reviewed changes
common/src/db.rs
Transaction(&'db DatabaseTransaction),
}

#[async_trait::async_trait]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, even with the current layout, a sensible impl of Deref might suffice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure who "you're" is in this case, so what is he right about?

@bobmcwhirter bobmcwhirter merged commit 3910159 into trustification:main Mar 15, 2024
3 checks passed
@ctron ctron deleted the feature/import_3 branch March 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrossley3 jcrossley3 jcrossley3 left review comments

@bobmcwhirter bobmcwhirter bobmcwhirter approved these changes

@helio-frota helio-frota helio-frota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctron @jcrossley3 @bobmcwhirter @helio-frota