Rename 'AuthenticatedEncryption' class to 'Encryption' #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spewu Could you please review and provide feedback, or ask a current TrustPilot employee to do so? Thank you in advance! |
spewu
approved these changes
Jun 6, 2020
|
@refactorsaurusrex thanks - looks good. I will try to get a hold of someone who can merge and release it |
irq
suggested changes
Jun 8, 2020
There was a problem hiding this comment.
@refactorsaurusrex Thanks for the PR!
Two small change requests, but otherwise it's good to merge! :)
This change allows the class to be referenced without being redundantly qualified with the containing namespace name.
Although these changes are very minor, they will cause errors for package consumers when they upgrade to the latest version.
Done. Thanks! |
irq
approved these changes
Jun 9, 2020
|
@refactorsaurusrex Currently I don't have access to our nuget.org account. I will let you know when this is sorted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming this class allows it to be referenced without either of the following undesirable requirements.
using AuthenticatedEncryption;statement be placed within a consuming project's namespace. (After the rename, the using statement can be placed outside a namespace declaration, which is a common convention for many projects.)Additionally, I bumped the version number to
2.0.0because this change is breaking and updated the readme with a corrected example.Closes #11.