Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

Add EIP712TypedData support #23

Merged
merged 5 commits into from
Aug 30, 2018
Merged

Conversation

@hewigovens
Copy link
Contributor Author

@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #23 into master will increase coverage by 2.02%.
The diff coverage is 96.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   80.03%   82.05%   +2.02%     
==========================================
  Files          63       66       +3     
  Lines        2364     2675     +311     
==========================================
+ Hits         1892     2195     +303     
- Misses        472      480       +8
Impacted Files Coverage Δ
...thereum/Solidity/EIP712/EIP712TypedDataTests.swift 100% <100%> (ø)
...ces/Ethereum/Solidity/EIP712/EIP712TypedData.swift 92.85% <92.85%> (ø)
Sources/Ethereum/Solidity/EIP712/GenericJSON.swift 94.93% <94.93%> (ø)
Sources/Ethereum/Solidity/ABIValue.swift 73.01% <0%> (+0.79%) ⬆️
Sources/Ethereum/Solidity/ABIEncoder.swift 89.36% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e649b4...8b0c5ad. Read the comment docs.

@alejandro-isaza
Copy link
Contributor

Let's add some documentation comments and bring the test coverage up.

Copy link
Contributor

@alejandro-isaza alejandro-isaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@hewigovens hewigovens changed the title Move EIP712TypedData into TrustCore Add EIP712TypedData support Aug 16, 2018
@vikmeup
Copy link
Contributor

vikmeup commented Aug 28, 2018

@hewigovens what's the latest on this?

@hewigovens
Copy link
Contributor Author

@vikmeup wait for two related PRs (Array type encoding, metamask support)

@vikmeup
Copy link
Contributor

vikmeup commented Aug 28, 2018

@hewigovens we could probably merge this one and then add those two that you mentioned?

@hewigovens
Copy link
Contributor Author

@vikmeup sure, let's create an issue to track this

@hewigovens hewigovens merged commit 4485ee9 into trustwallet:master Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants