Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timelock order(Binance)] Error: msg should not be nil #1141

Closed
roy1210 opened this issue Oct 14, 2020 · 1 comment · Fixed by #1143
Closed

[Timelock order(Binance)] Error: msg should not be nil #1141

roy1210 opened this issue Oct 14, 2020 · 1 comment · Fixed by #1143
Labels
bug Something isn't working

Comments

@roy1210
Copy link

roy1210 commented Oct 14, 2020

Hi @hewigovens @catenocrypt

Describe the bug
Fails broadcasting timelock_order.
Error: msg should not be nil will return after run sendRawTransaction:

          const request = context.wallet.walletconnect._formatRequest({
            method: "trust_signTransaction",
            params: [
              {
                network: NETWORK_ID,
                transaction: JSON.stringify(tx),
              },
            ],
          });
          window.mywall = context.wallet.walletconnect
          context.wallet.walletconnect
            ._sendCallRequest(request)
            .then((result) => {
              window.result = result;
              console.log('Successfully signed timeLock msg:', result);
             
             // Error: msg should not be nil 
              binance.bnbClient.sendRawTransaction(result, true)
                .then((response) => {
                  console.log('Response', response);
                  setSending(false);
                  setVisible(false);
                  getBalances();
                })

As per successfully running freeze_order reported in this issue, sendRawTransaction(result, true) should return the result of POST transaction to the Binance chain. The problem is returning Error: msg should not be nil when I sent timelock_order.
Kindly please help to investigate why such an error returns since created tx (JSON format's) based on WalletCore's proto messages.

Thank you for your support !! :D

To Reproduce
Please feel free to clone this branch. Timelock logic is in here

demo: https://beptool-fork-fm856hstj.vercel.app/

Expected behavior
binance.bnbClient.sendRawTransaction(result, true) returns 200.

Screenshots
tx values, request, and error message.
timelock console

Additional context
I'm using @walletconnect/client:^1.3.1 as per guideline in the latest Docs

@roy1210 roy1210 added the bug Something isn't working label Oct 14, 2020
@roy1210 roy1210 changed the title Timelock(Binance): Error: msg should not be nil [Timelock order(Binance)] Error: msg should not be nil Oct 14, 2020
@hewigovens
Copy link
Contributor

let's track this issue here: trustwallet/developer#148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants