Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Binance] Fix timelock unlock signature error #1143

Merged
merged 3 commits into from Oct 18, 2020

Conversation

hewigovens
Copy link
Contributor

Fixes #1141, mainnet tests in swift added

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #1143 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files         430      430           
  Lines       12716    12719    +3     
=======================================
+ Hits        12112    12115    +3     
  Misses        604      604           
Impacted Files Coverage Δ
src/Binance/Serialization.cpp 97.81% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5770a...b1c8566. Read the comment docs.

@hewigovens hewigovens merged commit ba9654f into master Oct 18, 2020
@hewigovens hewigovens deleted the xt/binance-timelock-fix branch October 18, 2020 22:45
cornbread78 pushed a commit to cornbread78/wallet-core that referenced this pull request Dec 22, 2021
* Fix timelock unlock signature error, add mainnet tests
* add relook test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Timelock order(Binance)] Error: msg should not be nil
3 participants