Fix buffer over-reads #1753
Merged
Fix buffer over-reads #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hewigovens
approved these changes
Nov 2, 2021
|
Debug asserts are thrown on these cases when running in Debug mode compiled under Visual Studio. Didn't find anything significant in the compiler warnings so far. (Mostly just implicit type casts and const correctness.) |
|
I have reworked a bit the RLP checks. In some cases the check was there a few lines above. I have extended the error messages (to be more informative). |
optout21
approved these changes
Nov 2, 2021
hewigovens
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes buffer overruns.
Testing instructions
Run the testing suite using a debug build with out of bounds checks enabled.
Types of changes
Bug fix (non-breaking change which fixes an issue)