Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Solana compilation error #1761

Merged
merged 1 commit into from
Nov 6, 2021
Merged

fix Solana compilation error #1761

merged 1 commit into from
Nov 6, 2021

Conversation

cryptodev100
Copy link
Contributor

This fixes the following compilation-error:

[ 18%] Building CXX object CMakeFiles/TrustWalletCore.dir/src/Solana/Signer.cpp.o
/home/felix/trustwallet-core/src/Solana/Signer.cpp:56:22: error: no member named 'optional' in namespace 'std'
                std::optional<Address> stakeAddress;

@hewigovens
Copy link
Contributor

What's your toolchain? It works on CI tho

@hewigovens hewigovens merged commit ba10def into trustwallet:master Nov 6, 2021
@cryptodev100
Copy link
Contributor Author

cryptodev100 commented Nov 8, 2021 •
edited

Thanks for merging, my toolchain is a set of Manjaro-Linux packages (similar to Arch-Linux).
I installed most of my packages with Pacman.
I have no clue why it compiled on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hewigovens hewigovens hewigovens approved these changes

@optout21 optout21 optout21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cryptodev100 @hewigovens @optout21