[Encryption]: add support for aes-256-ctr #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milerius
changed the title
Milerius
requested review from
hewigovens,
optout21 and
miloserdow
as code owners
miloserdow
reviewed
Nov 15, 2022
optout21
suggested changes
Nov 15, 2022
|
Let's add AES-CBC tests as well |
That's not the goal of this pull request. Only adding aes 256 ctr is the purpose for this pr |
optout21
previously approved these changes
Nov 18, 2022
hewigovens
reviewed
Nov 18, 2022
Milerius
force-pushed
the
m/aes_256_ctr
branch
from
3398f9c
to
6b20999
Compare
hewigovens
approved these changes
Nov 21, 2022
optout21
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #2701
How to test
Run C++ unit tests
Run wasm tests
Run kotlin tests
Run swift tests