Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dockerfile] Add missing include #3061

Merged
merged 5 commits into from
Apr 11, 2023
Merged

[Dockerfile] Add missing include #3061

merged 5 commits into from
Apr 11, 2023

Conversation

hewigovens
Copy link
Contributor

@hewigovens hewigovens commented Apr 11, 2023

Reported from @iCell, failed both on CI https://github.com/trustwallet/wallet-core/actions/runs/4383705487 and locally

Changes:

  • Replace git clone with COPY, this should make CI easier to test later
  • Move go installation step to comments

How to test locally: docker build . --platform linux/amd64

Succeeded on CI: https://github.com/trustwallet/wallet-core/actions/runs/4663344683/jobs/8254583205?pr=3061

@hewigovens hewigovens marked this pull request as ready for review April 11, 2023 03:33
@Milerius Milerius merged commit b8a050d into master Apr 11, 2023
13 checks passed
@Milerius Milerius deleted the h/docker-fix branch April 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants