Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Ethersocial Network #331

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Apr 16, 2019

Description

add Ethersocial Network (ESN) support

Testing instructions

./bootstrap.sh or make -C build tests

Types of changes

Ethersocial Network support added

Checklist

  • Add tests to cover changes as needed.

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #331 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   80.14%   80.15%   +0.01%     
==========================================
  Files         195      195              
  Lines        4839     4843       +4     
==========================================
+ Hits         3878     3882       +4     
  Misses        961      961
Impacted Files Coverage Δ
src/Coin.cpp 72.8% <ø> (ø) ⬆️
src/interface/TWCoinTypeConfiguration.cpp 76.23% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d30894...8d4a5ed. Read the comment docs.

@hackmod hackmod changed the title WIP: support Ethersocial Network support Ethersocial Network Apr 16, 2019
@hackmod
Copy link
Contributor Author

hackmod commented Apr 16, 2019

squashed and rebased.

@hewigovens
Copy link
Contributor

hewigovens commented Apr 17, 2019

only coin type and chain id are different from ethereum?

@hackmod
Copy link
Contributor Author

hackmod commented Apr 17, 2019

only coin type and chain id are different from ethereum?

yes,
like as Callistio or GoChain that already supported by TrustWallet.

@hewigovens hewigovens merged commit a7b7571 into trustwallet:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants