Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swap]: Fix BSC swap #3549

Merged
merged 2 commits into from
Nov 10, 2023
Merged

[Swap]: Fix BSC swap #3549

merged 2 commits into from
Nov 10, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Fix ETH memo for ->BSC swap.

Same as #3548, but targets 3.3.x

How to test

Run C++ tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@Milerius Milerius merged commit 19174fc into master-3 Nov 10, 2023
11 of 12 checks passed
@Milerius Milerius deleted the s/thorswap-bsc branch November 10, 2023 14:50
vm-px pushed a commit to vm-px/wallet-core that referenced this pull request Apr 30, 2024
@satoshiotomakan @vm-px
[Swap]: Fix BSC swap (trustwallet#3549)
e897014 
* [THORSwap]: Fix memo for ->BSC swap

* [THORSwap]: Fix Linux CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

@lamafab lamafab Awaiting requested review from lamafab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@satoshiotomakan @Milerius