Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Binance]: Add cosmos-sdk/MsgSideChainStakeMigration message type #3783

Merged
merged 4 commits into from Apr 11, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Add cosmos-sdk/MsgSideChainStakeMigration message type to allow BNB Beacon Chain users to migrate their stake amounts on Binance Smart Chain in one transaction.

https://github.com/bnb-chain/bnc-cosmos-sdk/blob/master/x/stake/types/stake_migration.go#L29-L35

Additional info
JS SDK sample : https://github.com/bnb-chain/javascript-sdk/pull/408/files

How to test

Run Rust tests

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Apr 9, 2024

Binary size comparison

➡️ aarch64-apple-ios: 11.36 MB

➡️ aarch64-apple-ios-sim: 11.36 MB

➡️ aarch64-linux-android: 14.63 MB

➡️ armv7-linux-androideabi: 12.31 MB

➡️ wasm32-unknown-emscripten: 10.10 MB

Copy link
Member

@rkokhatskyi rkokhatskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The migration worked as it should

@satoshiotomakan satoshiotomakan merged commit 70f8636 into master Apr 11, 2024
13 checks passed
@satoshiotomakan satoshiotomakan deleted the s/bnb-stake-migration branch April 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants