Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return no tiers in GET content tiers API #16047

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

farhan787
Copy link

Fixed GET content tiers api, now returns no tiers if paid membership is not setup.

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

This resolves the #15759 issue, where we shouldn't return any tiers in GET api/content/tiers if paid membership is not setup by owner.

@ErisDS I'm new to this repo, I've very little to no context of your business to code terminologies.

  1. I've used the boolean key if stripe is connected to check if paid membership is enabled or not, let me know if it's correct or needs changes.
  2. I'm looking forward to contribute more to the project and any coding style or architectural docs would be really helpful to know the context and implementation of the features.

@ErisDS ErisDS requested a review from allouis January 2, 2023 19:37
@allouis
Copy link
Contributor

allouis commented Jan 11, 2023

Hey @farhan787 - thanks for the PR! We're just having some internal discussions about the best way to fix this - sorry for the delay! It's not been forgotten about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants