Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract mongo too, return proper error #14

Merged
merged 5 commits into from
Apr 1, 2022
Merged

fix: extract mongo too, return proper error #14

merged 5 commits into from
Apr 1, 2022

Conversation

shlomi-dr
Copy link
Contributor

@shlomi-dr shlomi-dr commented Mar 30, 2022 •
edited
Loading

Return proper error and extract mongo binary itself for replica-set to work

fixes #13

@saniales saniales self-requested a review March 30, 2022 08:31
saniales
saniales requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@saniales saniales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

mongobin/getOrDownload.go Outdated Show resolved Hide resolved
mongobin/getOrDownload.go Show resolved Hide resolved
@saniales saniales merged commit 809c766 into tryvium-travels:main Apr 1, 2022
@shlomi-dr shlomi-dr deleted the shlomi/fix-replica-set branch April 1, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saniales saniales saniales approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't start memmongo with replicaset - panic with wrong error returned
2 participants
@shlomi-dr @saniales